linux-ext4 - Re: [PATCH] mbcache: fix to detect failure of register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160516153140.GE21714@quack2.suse.cz>
Date:	Mon, 16 May 2016 17:31:40 +0200
From:	Jan Kara <jack@...e.cz>
To:	Chao Yu <chao@...nel.org>
Cc:	tytso@....edu, jack@...e.cz, viro@...iv.linux.org.uk,
	linux-ext4@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	Chao Yu <yuchao0@...wei.com>
Subject: Re: [PATCH] mbcache: fix to detect failure of register_shrinker

On Mon 16-05-16 23:16:38, Chao Yu wrote:
> From: Chao Yu <yuchao0@...wei.com>
> 
> register_shrinker in mb_cache_create may fail due to no memory. This
> patch fixes to do the check of return value of register_shrinker and
> handle the error case, otherwise mb_cache_create may return with no
> error, but losing the inner shrinker.
> 
> Signed-off-by: Chao Yu <yuchao0@...wei.com>

Thanks for fixing this. The patch looks good. You can add:

Reviewed-by: Jan Kara <jack@...e.cz>

								Honza

-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html