linux-ext4 - Re: xfstests generic/130 hang with non-4k block size ext4 on 4.7-rc1 kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <pan$6abef$45fa540$7a7a0c36$ef55c356@applied-asynchrony.com>
Date:	Wed, 8 Jun 2016 14:23:49 +0000 (UTC)
From:	Holger Hoffstätte 
	<holger@...lied-asynchrony.com>
To:	linux-ext4@...r.kernel.org
Subject: Re: xfstests generic/130 hang with non-4k block size ext4 on
 4.7-rc1 kernel

On Wed, 08 Jun 2016 14:56:31 +0200, Jan Kara wrote:
(snip)
> Attached patch fixes the issue for me. I'll submit it once a full xfstests
> run finishes for it (which may take a while as our server room is currently
> moving to a different place).
> 
> 								Honza
> -- 
> Jan Kara <jack@...e.com>
> SUSE Labs, CR
> From 3a120841a5d9a6c42bf196389467e9e663cf1cf8 Mon Sep 17 00:00:00 2001
> From: Jan Kara <jack@...e.cz>
> Date: Wed, 8 Jun 2016 10:01:45 +0200
> Subject: [PATCH] ext4: Fix deadlock during page writeback
> 
> Commit 06bd3c36a733 (ext4: fix data exposure after a crash) uncovered a
> deadlock in ext4_writepages() which was previously much harder to hit.
> After this commit xfstest generic/130 reproduces the deadlock on small
> filesystems.

Since you marked this for -stable, just a heads-up that the previous patch
for the data exposure was rejected from -stable (see [1]) because it
has the mismatching "!IS_NOQUOTA(inode) &&" line, which didn't exist
until 4.6. I removed it locally but Greg probably wants an official patch.

So both this and the previous patch need to be submitted.

-h

[1] http://permalink.gmane.org/gmane.linux.kernel.stable/18074{4,5,6}

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html