linux-ext4 - Re: xfstests generic/130 hang with non-4k block size ext4 on 4.7-rc1 kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160609145917.GA19882@quack2.suse.cz>
Date:	Thu, 9 Jun 2016 16:59:17 +0200
From:	Jan Kara <jack@...e.cz>
To:	Holger Hoffstätte 
	<holger@...lied-asynchrony.com>
Cc:	linux-ext4@...r.kernel.org
Subject: Re: xfstests generic/130 hang with non-4k block size ext4 on 4.7-rc1
 kernel

Please use reply-to-all when replying to emails. Usually I read mailing
lists with much smaller frequency than directly sent email...

On Wed 08-06-16 14:23:49, Holger Hoffstätte wrote:
> On Wed, 08 Jun 2016 14:56:31 +0200, Jan Kara wrote:
> (snip)
> > Attached patch fixes the issue for me. I'll submit it once a full xfstests
> > run finishes for it (which may take a while as our server room is currently
> > moving to a different place).
> > 
> > 								Honza
> > -- 
> > Jan Kara <jack@...e.com>
> > SUSE Labs, CR
> > From 3a120841a5d9a6c42bf196389467e9e663cf1cf8 Mon Sep 17 00:00:00 2001
> > From: Jan Kara <jack@...e.cz>
> > Date: Wed, 8 Jun 2016 10:01:45 +0200
> > Subject: [PATCH] ext4: Fix deadlock during page writeback
> > 
> > Commit 06bd3c36a733 (ext4: fix data exposure after a crash) uncovered a
> > deadlock in ext4_writepages() which was previously much harder to hit.
> > After this commit xfstest generic/130 reproduces the deadlock on small
> > filesystems.
> 
> Since you marked this for -stable, just a heads-up that the previous patch
> for the data exposure was rejected from -stable (see [1]) because it
> has the mismatching "!IS_NOQUOTA(inode) &&" line, which didn't exist
> until 4.6. I removed it locally but Greg probably wants an official patch.
> 
> So both this and the previous patch need to be submitted.

This patch is actually independent fix to the previous one. Just the
previous patch made the bug more visible. Regarding the backport - yeah, I
have it on my todo list.

								Honza
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html