linux-ext4 - Re: [PATCH -v2] ext4: optimize ext4_should_retry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <017458DB-A479-4462-BB81-30C321F593B4@dilger.ca>
Date:	Thu, 16 Jun 2016 14:11:28 -0600
From:	Andreas Dilger <adilger@...ger.ca>
To:	Jan Kara <jack@...e.cz>
Cc:	Theodore Ts'o <tytso@....edu>,
	Ext4 Developers List <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH -v2] ext4: optimize ext4_should_retry_alloc() to improve ENOSPC performance

On Jun 16, 2016, at 1:20 PM, Jan Kara <jack@...e.cz> wrote:
> 
> Well, since ext4_mb_free_metadata() is the only user of
> ext4_journal_callback_add(), ext4_journal_callback_add() won't have any
> user after your patch. Maybe we could just stop playing these abstraction
> games nobody currently uses and just implement a helper function to add
> freeing callback to the transaction list including increment of the pending
> counter.

We use the journal callback for Lustre servers.  Please don't remove it.

Cheers, Andreas






Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)