linux-ext4 - Re: [PATCH] ext4: don't call ext4_should_journal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160704150245.GD29557@thunk.org>
Date:	Mon, 4 Jul 2016 11:02:45 -0400
From:	Theodore Ts'o <tytso@....edu>
To:	Vegard Nossum <vegard.nossum@...cle.com>
Cc:	Jan Kara <jack@...e.cz>, linux-ext4@...r.kernel.org,
	linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH] ext4: don't call ext4_should_journal_data() on the
 journal inode

Thanks, I've reworded the commit description as follows:

  ext4: don't call ext4_should_journal_data() on the journal inode

  If ext4_fill_super() fails early, it's possible for
  ext4_evict_inode() to call ext4_should_journal_data() before
  superblock options and flags are fully set up.  In that case, the
  iput() on the journal inode can end up causing a BUG().

  Work around this problem by reordering the tests so we only call
  ext4_should_journal_data() after we know it's not the journal inode.

  Fixes: 2d859db3e4 ("ext4: fix data corruption in inodes with journalled data")
  Fixes: 2b405bfa84 ("ext4: fix data=journal fast mount/umount hang")
  Cc: Jan Kara <jack@...e.cz>
  Cc: stable@...r.kernel.org
  Signed-off-by: Vegard Nossum <vegard.nossum@...cle.com>
  Signed-off-by: Theodore Ts'o <tytso@....edu>
  Reviewed-by: Jan Kara <jack@...e.cz>

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html