linux-ext4 - Re: [PATCH RESEND] e2fsck: update j_tail

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160706031115.GO15193@thunk.org>
Date:	Tue, 5 Jul 2016 23:11:15 -0400
From:	Theodore Ts'o <tytso@....edu>
To:	Daeho Jeong <daeho.jeong@...sung.com>
Cc:	linux-ext4@...r.kernel.org, Youngjin Gil <youngjin.gil@...sung.com>
Subject: Re: [PATCH RESEND] e2fsck: update j_tail_sequence after recovery

On Wed, Jul 06, 2016 at 09:10:39AM +0900, Daeho Jeong wrote:
> When journal is released, s_sequence is set to j_tail_sequence.
> But, currently, even if the recovery process is successfully completed,
> the j_tail_sequence and, finally, s_sequence are never changed. By this,
> when we repeat doing power-off the device suddenly and executing e2fsck
> without full scan before mount, the s_sequence number will never change
> and, in a very rare case, newly generated journal logs will be
> surprisingly grafted to the old journal logs. In this case, out-of-date
> metadata log can be replayed on the filesystem area and the filesystem
> can be crashed unintentionally by journal recovery process. Therefore,
> we need to update j_tail_sequence after recovery process is successfully
> completed in e2fsck.
> 
> Youngjin had repeated this test and found the problem. With our test,
> the filesystem crash occurred within 4 hours.
> 
> Signed-off-by: Youngjin Gil <youngjin.gil@...sung.com>
> Signed-off-by: Daeho Jeong <daeho.jeong@...sung.com>

Applied, thanks.

						 - Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html