linux-ext4 - Re: [PATCH] ext4: short-cut orphan cleanup on error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160715034904.GC26465@thunk.org>
Date:	Thu, 14 Jul 2016 23:49:04 -0400
From:	Theodore Ts'o <tytso@....edu>
To:	Vegard Nossum <vegard.nossum@...cle.com>
Cc:	linux-ext4@...r.kernel.org, Jan Kara <jack@...e.cz>
Subject: Re: [PATCH] ext4: short-cut orphan cleanup on error

On Sun, Jul 10, 2016 at 12:50:04AM +0200, Vegard Nossum wrote:
> If we encounter a filesystem error during orphan cleanup, we should stop.
> Otherwise, we may end up in an infinite loop where the same inode is
> processed again and again.
> 
>     EXT4-fs (loop0): warning: checktime reached, running e2fsck is recommended
>     EXT4-fs error (device loop0): ext4_mb_generate_buddy:758: group 2, block bitmap and bg descriptor inconsistent: 6117 vs 0 free clusters
>     Aborting journal on device loop0-8.
>     EXT4-fs (loop0): Remounting filesystem read-only
>     EXT4-fs error (device loop0) in ext4_free_blocks:4895: Journal has aborted
>     EXT4-fs error (device loop0) in ext4_do_update_inode:4893: Journal has aborted
>     EXT4-fs error (device loop0) in ext4_do_update_inode:4893: Journal has aborted
>     EXT4-fs error (device loop0) in ext4_ext_remove_space:3068: IO failure
>     EXT4-fs error (device loop0) in ext4_ext_truncate:4667: Journal has aborted
>     EXT4-fs error (device loop0) in ext4_orphan_del:2927: Journal has aborted
>     EXT4-fs error (device loop0) in ext4_do_update_inode:4893: Journal has aborted
>     EXT4-fs (loop0): Inode 16 (00000000618192a0): orphan list check failed!
>     [...]
>     EXT4-fs (loop0): Inode 16 (0000000061819748): orphan list check failed!
>     [...]
>     EXT4-fs (loop0): Inode 16 (0000000061819bf0): orphan list check failed!
>     [...]
> 
> See-also: c9eb13a9105 ("ext4: fix hang when processing corrupted orphaned inode list")
> Cc: Jan Kara <jack@...e.cz>
> Signed-off-by: Vegard Nossum <vegard.nossum@...cle.com>

Applied, thanks.

							- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html