linux-ext4 - Re: [PATCH 1/1] mm/block: convert rw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <10142950-64f9-4054-55c7-82f0758d2099@kernel.dk>
Date:	Fri, 5 Aug 2016 07:52:54 -0600
From:	Jens Axboe <axboe@...nel.dk>
To:	Christoph Hellwig <hch@...radead.org>,
	Mike Christie <mchristi@...hat.com>
Cc:	ross.zwisler@...ux.intel.com, linux-ext4@...r.kernel.org,
	linux-block@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	david@...morbit.com, minchan@...nel.org, ngupta@...are.org,
	vishal.l.verma@...el.com
Subject: Re: [PATCH 1/1] mm/block: convert rw_page users to bio op use

On 08/05/2016 01:57 AM, Christoph Hellwig wrote:
>>
>> The rw_page users were not converted to use bio/req ops. As a result
>> bdev_write_page is not passing down REQ_OP_WRITE and the IOs will
>> be sent down as reads.
>
> Can we just get rid of REQ_OP_WRITE enum for the ->rw_page interface
> and pass a 'bool write'?  If not I'd prefer to avoid using op_is_write
> as much as possible - it's a confusing interface if we really want
> to do a switch on read vs write vs invalid.

That's a really good point, especially since the op_flags was dropped as 
well. I'll cook that up.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html