linux-ext4 - Re: ext4: fix reference counting bug on block allocation error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <57B0BA84.1000600@oracle.com>
Date:	Sun, 14 Aug 2016 20:37:56 +0200
From:	Vegard Nossum <vegard.nossum@...cle.com>
To:	Greg KH <gregkh@...uxfoundation.org>,
	"Theodore Ts'o" <tytso@....edu>, adilger.kernel@...ger.ca
Cc:	linux-ext4@...r.kernel.org,
	"Aneesh Kumar K.V" <aneesh.kumar@...ux.vnet.ibm.com>
Subject: Re: ext4: fix reference counting bug on block allocation error

On 08/14/2016 08:32 PM, Greg KH wrote:
> Hi Vegard and ext4 developers,
>
> The patch below, in Linus's tree, references a patch in the Fixes: line
> that is not in Linus's tree (neither the git commit id, nor the subject
> line.)
>

It seems to exist?

 >> Fixes: 8556e8f3b6 ("ext4: Don't allow new groups to be added during 
block allocation")

https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=8556e8f3b6c4c11601ce1e9ea8090a6d8bd5daae

> That's a bit confusing, what is this patch supposed to be fixing up?
> What stable tree(s) should it go to if the original patch it fixes isn't
> even in any tree?

The referenced commit adds the ext4_mb_release_context(ac); line which
is what is causing problems because that releases the context which is
still in fact in use.

>
> confused,

Confused too :-)


Vegard
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html