linux-ext4 - [STABLE CHERRYPICK] ext4: avoid modifying checksum fields directly during checksum verification

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160906022955.qopdwuznvtqlwofq@thunk.org>
Date:   Mon, 5 Sep 2016 22:29:55 -0400
From:   Theodore Ts'o <tytso@....edu>
To:     stable@...nel.org
Cc:     linux-ext4@...r.kernel.org,
        Török Edwin <edwin@...rok.net>
Subject: [STABLE CHERRYPICK] ext4: avoid modifying checksum fields directly
 during checksum verification

Hi, please cherry pick the following commit into the stable kernels.
The commit landed in 4.8-rc1.  It wasn't marked with a cc:
stable@...nel.org, but it should be backported since it affecting a
number of users who are trying to use ext4's metadata checksum
feature.

Thanks!!

commit b47820edd1634dc1208f9212b7ecfb4230610a23
Author: Daeho Jeong <daeho.jeong@...sung.com>
Date:   Sun Jul 3 17:51:39 2016 -0400

    ext4: avoid modifying checksum fields directly during checksum verification
    
    We temporally change checksum fields in buffers of some types of
    metadata into '0' for verifying the checksum values. By doing this
    without locking the buffer, some metadata's checksums, which are
    being committed or written back to the storage, could be damaged.
    In our test, several metadata blocks were found with damaged metadata
    checksum value during recovery process. When we only verify the
    checksum value, we have to avoid modifying checksum fields directly.
    
    Signed-off-by: Daeho Jeong <daeho.jeong@...sung.com>
    Signed-off-by: Youngjin Gil <youngjin.gil@...sung.com>
    Signed-off-by: Theodore Ts'o <tytso@....edu>
    Reviewed-by: Darrick J. Wong <darrick.wong@...cle.com>

						- Ted
						
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html