linux-ext4 - Re: [PATCH RESEND] ext4: Cleanup ext4_sync

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160906032232.ofcyyy6albwhdh5s@thunk.org>
Date:   Mon, 5 Sep 2016 23:22:32 -0400
From:   Theodore Ts'o <tytso@....edu>
To:     Jan Kara <jack@...e.cz>
Cc:     linux-ext4@...r.kernel.org
Subject: Re: [PATCH RESEND] ext4: Cleanup ext4_sync_parent()

On Wed, Aug 10, 2016 at 11:25:45AM +0200, Jan Kara wrote:
> A condition !hlist_empty(&inode->i_dentry) is always true for open file.
> Just remove it. Also ext4_sync_parent() could use some explanation why
> races with rmdir() are not an issue - add a comment explaining that.
> 
> Reported-by: Al Viro <viro@...IV.linux.org.uk>
> Signed-off-by: Jan Kara <jack@...e.cz>

Thanks, applied.

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html