linux-ext4 - Re: [PATCH] blockgroup_lock.h: remove debris from bgl_lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <8CA6154E-320A-4AB3-891F-05E097679438@dilger.ca>
Date:   Wed, 14 Sep 2016 15:09:04 -0600
From:   Andreas Dilger <adilger@...ger.ca>
To:     Eric Biggers <ebiggers@...gle.com>
Cc:     Theodore Ts'o <tytso@....edu>,
        linux-ext4 <linux-ext4@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] blockgroup_lock.h: remove debris from bgl_lock_ptr() conversion

On Sep 14, 2016, at 1:27 PM, Eric Biggers <ebiggers@...gle.com> wrote:
> 
> An obsolete comment and extra parentheses were left over from when the
> sb_bgl_lock() macro was replaced with the bgl_lock_ptr() function.
> 
> Signed-off-by: Eric Biggers <ebiggers@...gle.com>

Reviewed-by: Andreas Dilger <adilger@...ger.ca>

> ---
> include/linux/blockgroup_lock.h | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/include/linux/blockgroup_lock.h b/include/linux/blockgroup_lock.h
> index e44b88b..61b583d 100644
> --- a/include/linux/blockgroup_lock.h
> +++ b/include/linux/blockgroup_lock.h
> @@ -49,14 +49,10 @@ static inline void bgl_lock_init(struct blockgroup_lock *bgl)
> 		spin_lock_init(&bgl->locks[i].lock);
> }
> 
> -/*
> - * The accessor is a macro so we can embed a blockgroup_lock into different
> - * superblock types
> - */
> static inline spinlock_t *
> bgl_lock_ptr(struct blockgroup_lock *bgl, unsigned int block_group)
> {
> -	return &bgl->locks[(block_group) & (NR_BG_LOCKS-1)].lock;
> +	return &bgl->locks[block_group & (NR_BG_LOCKS-1)].lock;
> }
> 
> #endif
> --
> 2.8.0.rc3.226.g39d4020
> 


Cheers, Andreas






Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)