linux-ext4 - Re: fscrypto: improved validation when loading inode encryption metadata

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160915202603.GC52239@jaegeuk>
Date:   Thu, 15 Sep 2016 13:26:03 -0700
From:   Jaegeuk Kim <jaegeuk@...nel.org>
To:     Theodore Ts'o <tytso@....edu>
Cc:     Eric Biggers <ebiggers@...gle.com>, linux-fsdevel@...r.kernel.org,
        linux-ext4@...r.kernel.org, linux-f2fs-devel@...ts.sourceforge.net
Subject: Re: fscrypto: improved validation when loading inode encryption
 metadata

On Thu, Sep 15, 2016 at 04:16:56PM -0400, Theodore Ts'o wrote:
> On Mon, Sep 12, 2016 at 12:24:00PM -0700, Eric Biggers wrote:
> > - Validate fscrypt_context.format and fscrypt_context.flags.  If
> >   unrecognized values are set, then the kernel may not know how to
> >   interpret the encrypted file, so it should fail the operation.
> > 
> > - Validate that AES_256_XTS is used for contents and that AES_256_CTS is
> >   used for filenames.  It was previously possible for the kernel to
> >   accept these reversed, though it would have taken manual editing of
> >   the block device.  This was not intended.
> > 
> > - Fail cleanly rather than BUG()-ing if a file has an unexpected type.
> > 
> > Signed-off-by: Eric Biggers <ebiggers@...gle.com>

Reviewed-by: Jaegeuk Kim <jaegeuk@...nel.org>

> Thanks, applied.  (I plan to carry Eric's fscrypto changes ext4 git
> tree; Jaeguk, I assume you have no objections?)

No objection.

Thanks,

> 
> 		   	       	       	   	- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html