linux-ext4 - Re: [PATCH] jbd2: Fix lockdep annotation in add_transaction

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160922154718.v4drz3ar64saaxnd@thunk.org>
Date:   Thu, 22 Sep 2016 11:47:18 -0400
From:   Theodore Ts'o <tytso@....edu>
To:     Jan Kara <jack@...e.cz>
Cc:     linux-ext4@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH] jbd2: Fix lockdep annotation in add_transaction_credits()

On Mon, Sep 19, 2016 at 02:30:43PM +0200, Jan Kara wrote:
> Thomas has reported a lockdep splat hitting in
> add_transaction_credits(). The problem is that that function calls
> jbd2_might_wait_for_commit() while holding j_state_lock which is wrong
> (we do not really wait for transaction commit while holding that lock).
> 
> Fix the problem by moving jbd2_might_wait_for_commit() into places where
> we are ready to wait for transaction commit and thus j_state_lock is
> unlocked.
> 
> Fixes: 1eaa566d368b214d99cbb973647c1b0b8102a9ae
> Reported-by: Thomas Gleixner <tglx@...utronix.de>
> Signed-off-by: Jan Kara <jack@...e.cz>

Thanks, applied.

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html