linux-ext4 - Re: [PATCH] fstests: make some xfs project quota tests generic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a834fc9c-c406-022f-8304-2ed54c65bc9b@sandeen.net>
Date:   Fri, 23 Sep 2016 07:20:40 -0500
From:   Eric Sandeen <sandeen@...deen.net>
To:     Eryu Guan <eguan@...hat.com>, Eric Sandeen <sandeen@...hat.com>
Cc:     fstests <fstests@...r.kernel.org>,
        linux-xfs <linux-xfs@...r.kernel.org>,
        "linux-ext4@...r.kernel.org" <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH] fstests: make some xfs project quota tests generic

On 9/22/16 11:25 PM, Eryu Guan wrote:
>> @@ -210,16 +226,23 @@ _qmount_option()
>> >  		-e 's/gquota/QUOTA/g'      \
>> >  		-e 's/grpquota/QUOTA/g'    \
>> >  		-e 's/pquota/QUOTA/g'      \
>> > -		-e 's/prjquota/QUOTA/g'      \
>> > +		-e 's/prjquota/QUOTA/g'    \
>> >  		-e 's/quota/QUOTA/g'       \
>> >  		-e 's/uqnoenforce/QUOTA/g' \
>> >  		-e 's/gqnoenforce/QUOTA/g' \
>> >  		-e 's/pqnoenforce/QUOTA/g' \
>> >  		-e 's/qnoenforce/QUOTA/g'  \
>> > -		-e "s/QUOTA/$1/g"`
>> > +		-e "s/QUOTA/$OPTS/g"`
>> >  
>> > +	# ext4 doesn't _do_ "-o pquota/prjquota" because reasons
>> > +	# Switch it to "quota" to enable mkfs-time pquota
>> > +	if [ "$FSTYP" == "ext4" ]; then
>> > +		OPTS=`echo $OPTS \
>> > +		| sed	-e 's/pquota/quota/g'	\
>> > +			-e 's/prjquota/quota/g'`
>> > +	fi
> This replaces "grpquota" to "grquota" and mount failed because of
> unknown mount option "grquota". The following change works for me:
> 
> -             | sed   -e 's/pquota/quota/g'   \
> +             | sed   -e 's/\bpquota/quota/g' \
> 
> If you can give me an ack (or another fix), I can fold it into the
> original patch.

Eek .. yes, feel free to change that (and the other, unless you want
to make it a separate commit) - sorry, not sure how I missed that.

Thanks,
-Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html