linux-ext4 - Re: [PATCH] ext4: ext4_mb_mark_free_simple: Fix integer value truncation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <2AE0DCBF-5AB6-47B2-B9F6-B738AFF2EAF2@dilger.ca>
Date:   Thu, 3 Nov 2016 13:32:33 -0600
From:   Andreas Dilger <adilger@...ger.ca>
To:     Chandan Rajendra <chandan@...ux.vnet.ibm.com>
Cc:     linux-ext4@...r.kernel.org, tytso@....edu, jack@...e.cz,
        aneesh.kumar@...ux.vnet.ibm.com, linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH] ext4: ext4_mb_mark_free_simple: Fix integer value truncation

On Nov 3, 2016, at 3:14 AM, Chandan Rajendra <chandan@...ux.vnet.ibm.com> wrote:
> 
> 'border' variable is set to a value of 2 times the block size of the
> underlying filesystem. With 64k block size, the resulting value won't
> fit into a 16-bit variable. Hence this commit changes the data type of
> 'border' to 'unsigned int'.
> 
> Signed-off-by: Chandan Rajendra <chandan@...ux.vnet.ibm.com>

Reviewed-by: Andreas Dilger <adilger@...ger.ca>

> ---
> fs/ext4/mballoc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
> index f418f55..a937ac7 100644
> --- a/fs/ext4/mballoc.c
> +++ b/fs/ext4/mballoc.c
> @@ -669,7 +669,7 @@ static void ext4_mb_mark_free_simple(struct super_block *sb,
> 	ext4_grpblk_t min;
> 	ext4_grpblk_t max;
> 	ext4_grpblk_t chunk;
> -	unsigned short border;
> +	unsigned int border;
> 
> 	BUG_ON(len > EXT4_CLUSTERS_PER_GROUP(sb));
> 
> --
> 2.5.5
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


Cheers, Andreas






Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)