linux-ext4 - Re: [PATCH 1/3] ext4: sanity check the block and cluster size at mount time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161118180054.g2qcasadx5aqqrva@thunk.org>
Date:   Fri, 18 Nov 2016 13:00:54 -0500
From:   Theodore Ts'o <tytso@....edu>
To:     Andreas Dilger <adilger@...ger.ca>
Cc:     Ext4 Developers List <linux-ext4@...r.kernel.org>, kernel@...p.com,
        bp@...en8.de, stable@...r.kernel.org
Subject: Re: [PATCH 1/3] ext4: sanity check the block and cluster size at
 mount time

On Fri, Nov 18, 2016 at 01:38:10AM -0700, Andreas Dilger wrote:
> > @@ -3567,7 +3567,15 @@ static int ext4_fill_super(struct super_block *sb, void *data, int silent)
> > 	if (blocksize < EXT4_MIN_BLOCK_SIZE ||
> > 	    blocksize > EXT4_MAX_BLOCK_SIZE) {
> > 		ext4_msg(sb, KERN_ERR,
> > -		       "Unsupported filesystem blocksize %d", blocksize);
> > +		       "Unsupported filesystem blocksize %d (%d)",
> 
> Would be good to indicate what the second value is, like "(%d bits)".

Good idea; I've annotated it as "log_block_size".

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html