linux-ext4 - Re: [ext4:dev 21/26] file.c:undefined reference to `dax_iomap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20161123081443.GG3973@quack2.suse.cz>
Date:   Wed, 23 Nov 2016 09:14:43 +0100
From:   Jan Kara <jack@...e.cz>
To:     Dave Chinner <david@...morbit.com>
Cc:     Jan Kara <jack@...e.cz>, Theodore Ts'o <tytso@....edu>,
        linux-ext4@...r.kernel.org
Subject: Re: [ext4:dev 21/26] file.c:undefined reference to `dax_iomap_fault'

On Wed 23-11-16 08:33:16, Dave Chinner wrote:
> > diff --git a/fs/ext4/Kconfig b/fs/ext4/Kconfig
> > index e38039fd96ff..7b90691e98c4 100644
> > --- a/fs/ext4/Kconfig
> > +++ b/fs/ext4/Kconfig
> > @@ -37,6 +37,7 @@ config EXT4_FS
> >  	select CRC16
> >  	select CRYPTO
> >  	select CRYPTO_CRC32C
> > +	select FS_IOMAP if FS_DAX
> 
> Shouldn't the FS_DAX config select FS_IOMAP unconditionally because
> it is now a hard config dependency in the DAX subsystem?

Yeah, that would be even better. Ted, can you add this cleanup patch as
well (attached)? Possibly also just ditch my previous ext4-specific patch
and remove relevant hunk from the attached one. Thanks!

								Honza
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR

View attachment "0001-dax-Select-CONFIG_FS_IOMAP.patch" of type "text/x-patch" (1514 bytes)