linux-ext4 - Re: [PATCH 2/5] mbcache: don't BUG() if entry cache cannot be allocated

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 28 Nov 2016 13:09:20 +0100
From:   Jan Kara <jack@...e.cz>
To:     Eric Biggers <ebiggers@...gle.com>
Cc:     linux-ext4@...r.kernel.org, Jan Kara <jack@...e.cz>,
        Andreas Gruenbacher <agruenba@...hat.com>
Subject: Re: [PATCH 2/5] mbcache: don't BUG() if entry cache cannot be
 allocated

On Sat 26-11-16 22:17:58, Eric Biggers wrote:
> mbcache can be a module that is loaded long after startup, when someone
> asks to mount an ext2 or ext4 filesystem.  Therefore it should not BUG()
> if kmem_cache_create() fails, but rather just fail the module load.
> 
> Signed-off-by: Eric Biggers <ebiggers@...gle.com>

Makes sense. You can add:

Reviewed-by: Jan Kara <jack@...e.cz>

								Honza

> ---
>  fs/mbcache.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/fs/mbcache.c b/fs/mbcache.c
> index 31e54c2..c56ab21 100644
> --- a/fs/mbcache.c
> +++ b/fs/mbcache.c
> @@ -420,7 +420,8 @@ static int __init mbcache_init(void)
>  	mb_entry_cache = kmem_cache_create("mbcache",
>  				sizeof(struct mb_cache_entry), 0,
>  				SLAB_RECLAIM_ACCOUNT|SLAB_MEM_SPREAD, NULL);
> -	BUG_ON(!mb_entry_cache);
> +	if (!mb_entry_cache)
> +		return -ENOMEM;
>  	return 0;
>  }
>  
> -- 
> 2.8.0.rc3.226.g39d4020
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html