linux-ext4 - Re: [PATCH 3/4] fscrypt: move non-public structures and constants to fscrypt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161129210658.GC52769@google.com>
Date:   Tue, 29 Nov 2016 13:06:58 -0800
From:   Eric Biggers <ebiggers@...gle.com>
To:     Theodore Ts'o <tytso@....edu>
Cc:     Linux Filesystem Development List <linux-fsdevel@...r.kernel.org>,
        Ext4 Developers List <linux-ext4@...r.kernel.org>,
        jaegeuk@...nel.org
Subject: Re: [PATCH 3/4] fscrypt: move non-public structures and constants to
 fscrypt_private.h

On Sat, Nov 26, 2016 at 11:41:54PM -0500, Theodore Ts'o wrote:
> Signed-off-by: Theodore Ts'o <tytso@....edu>
> ---
>  fs/crypto/crypto.c          |  2 +-
>  fs/crypto/fscrypt_private.h | 71 +++++++++++++++++++++++++++++++++++++++++++++
>  fs/crypto/policy.c          |  2 +-
>  include/linux/fscrypto.h    | 68 ++-----------------------------------------
>  4 files changed, 76 insertions(+), 67 deletions(-)
> 

This looks good to me.  There are however a few other things I think would
belong in the private header too, like the #includes of <linux/key.h> and
<crypto/skcipher.h>, the declaration of 'fscrypt_info_cachep', and some of the
inline functions.

Reviewed-by: Eric Biggers <ebiggers@...gle.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html