linux-ext4 - Re: [PATCH] ext4: disable pwsalt ioctl when encryption disabled by config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20161201165655.w56cyzojmuvoinnx@thunk.org>
Date:   Thu, 1 Dec 2016 11:56:55 -0500
From:   Theodore Ts'o <tytso@....edu>
To:     Eric Biggers <ebiggers@...gle.com>
Cc:     linux-ext4@...r.kernel.org,
        Andreas Dilger <adilger.kernel@...ger.ca>,
        Jaegeuk Kim <jaegeuk@...nel.org>,
        Richard Weinberger <richard@....at>
Subject: Re: [PATCH] ext4: disable pwsalt ioctl when encryption disabled by
 config

On Mon, Nov 21, 2016 at 04:23:12PM -0800, Eric Biggers wrote:
> On a CONFIG_EXT4_FS_ENCRYPTION=n kernel, the ioctls to get and set
> encryption policies were disabled but EXT4_IOC_GET_ENCRYPTION_PWSALT was
> not.  But there's no good reason to expose the pwsalt ioctl if the
> kernel doesn't support encryption.  The pwsalt ioctl was also disabled
> pre-4.8 (via ext4_sb_has_crypto() previously returning 0 when encryption
> was disabled by config) and seems to have been enabled by mistake when
> ext4 encryption was refactored to use fs/crypto/.  So let's disable it
> again.
> 
> Signed-off-by: Eric Biggers <ebiggers@...gle.com>

Thanks, applied.

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html