linux-ext4 - Re: [PATCH 3/5] mbcache: remove unnecessary module_get/module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161203204152.ljtscpzx2jbt5foy@thunk.org>
Date:   Sat, 3 Dec 2016 15:41:52 -0500
From:   Theodore Ts'o <tytso@....edu>
To:     Eric Biggers <ebiggers@...gle.com>
Cc:     linux-ext4@...r.kernel.org, Jan Kara <jack@...e.cz>,
        Andreas Gruenbacher <agruenba@...hat.com>
Subject: Re: [PATCH 3/5] mbcache: remove unnecessary module_get/module_put

On Sat, Nov 26, 2016 at 10:17:59PM -0800, Eric Biggers wrote:
> When mbcache is built as a module, any modules that use it (ext2 and/or
> ext4) will depend on its symbols directly, incrementing its reference
> count.  Therefore, there is no need to do module_get/module_put.
> 
> Also note that since the module_get/module_put were in the mbcache
> module itself, executing those lines of code was already dependent on
> another reference to the mbcache module being held.
> 
> Signed-off-by: Eric Biggers <ebiggers@...gle.com>

Thanks, applied.

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html