linux-ext4 - Re: [PATCH] ext4: Fix checks for data=ordered and journal_async

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20161203212244.dnhtzueim6pq6zj7@thunk.org>
Date:   Sat, 3 Dec 2016 16:22:44 -0500
From:   Theodore Ts'o <tytso@....edu>
To:     Jan Kara <jack@...e.cz>
Cc:     linux-ext4@...r.kernel.org, Wolfgang Walter <linux@...m.de>
Subject: Re: [PATCH] ext4: Fix checks for data=ordered and
 journal_async_commit options

On Mon, Nov 28, 2016 at 03:43:42PM +0100, Jan Kara wrote:
> Combination of data=ordered mode and journal_async_commit mount option
> is invalid. However the check in parse_options() fails to detect the
> case where we simply end up defaulting to data=ordered mode and we
> detect the problem only on remount which triggers hard to understand
> failure to remount the filesystem.
> 
> Fix the checking of mount options to take into account also the default
> mode by moving the check somewhat later in the mount sequence.
> 
> Reported-by: Wolfgang Walter <linux@...m.de>
> Signed-off-by: Jan Kara <jack@...e.cz>

Thanks, applied.

				- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html