linux-ext4 - Re: [PATCH 2/3] fscrypt: fix renaming and linking special files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <078aca9a-5239-18dd-6317-9d6f03c42770@nod.at>
Date:   Fri, 16 Dec 2016 13:22:55 +0100
From:   Richard Weinberger <richard@....at>
To:     Eric Biggers <ebiggers3@...il.com>, linux-fsdevel@...r.kernel.org
Cc:     "Theodore Y . Ts'o" <tytso@....edu>,
        Jaegeuk Kim <jaegeuk@...nel.org>, linux-ext4@...r.kernel.org,
        linux-f2fs-devel@...ts.sourceforge.net,
        David Gstir <david@...ma-star.at>,
        Eric Biggers <ebiggers@...gle.com>
Subject: Re: [PATCH 2/3] fscrypt: fix renaming and linking special files

On 15.12.2016 20:19, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@...gle.com>
> 
> Attempting to link a device node, named pipe, or socket file into an
> encrypted directory through rename(2) or link(2) always failed with
> EPERM.  This happened because fscrypt_permitted_context() saw that the
> file was unencrypted and forbid creating the link.  This behavior was
> unexpected because such files are never encrypted; only regular files,
> directories, and symlinks can be encrypted.
> 
> To fix this, make fscrypt_has_permitted_context() always return true on
> special files.
> 
> This will be covered by a test in my encryption xfstests patchset.
> 
> Fixes: 9bd8212f981e ("ext4 crypto: add encryption policy and password salt support")
> Signed-off-by: Eric Biggers <ebiggers@...gle.com>

Reviewed-by: Richard Weinberger <richard@....at>

Thanks,
//richard

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html