linux-ext4 - Re: [GIT PULL] Quota, fsnotify, and ext2 changes for 4.10-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20161219131832.GA24199@quack2.suse.cz>
Date:   Mon, 19 Dec 2016 14:18:32 +0100
From:   Jan Kara <jack@...e.cz>
To:     Linus Torvalds <torvalds@...ux-foundation.org>
Cc:     linux-fsdevel@...r.kernel.org, linux-ext4@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [GIT PULL] Quota, fsnotify, and ext2 changes for 4.10-rc1

Hello Linus,

On Mon 19-12-16 10:34:42, Jan Kara wrote:
>   could you please pull from
> 
> git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs.git for_linus
> 
> to get changes to locking of some quota operations from dedicated quota mutex
> to s_umount semaphore, a fsnotify fix and a simple ext2 fix.
> 
> Top of the tree is 5716863e0f82. The full shortlog is:

Just after sending this pull request I've received a report from 0-day
testing that a warning in dquot_disable() hits on remount. It is just a
cosmetic thing but still I'd prefer to have this fixed and not have to deal
with reports of this warning. So I have pushed out one additional commit
to for_linus branch:

2700e6067c72 "quota: Fix bogus warning in dquot_disable()"

Sorry for the noise. I'm now going to dig into why my personal testing
didn't actually spot this earlier...

								Honza
> 
> Darrick J. Wong (1):
>       ext2: reject inodes with negative size
> 
> Jan Kara (8):
>       fs: Provide function to get superblock with exclusive s_umount
>       quota: Hold s_umount in exclusive mode when enabling / disabling quotas
>       quota: Use s_umount protection for quota operations
>       ocfs2: Protect periodic quota syncing with s_umount semaphore
>       quota: Remove dqonoff_mutex from dquot_scan_active()
>       ocfs2: Use s_umount for quota recovery protection
>       quota: Remove dqonoff_mutex
>       fsnotify: Fix possible use-after-free in inode iteration on umount
> 
> The diffstat is
> 
>  fs/ext2/inode.c         |   4 ++
>  fs/notify/inode_mark.c  |  45 ++++------------
>  fs/ocfs2/quota_global.c |  10 +++-
>  fs/ocfs2/quota_local.c  |  11 ++--
>  fs/ocfs2/super.c        |   1 -
>  fs/quota/dquot.c        | 134 +++++++++++++++++-------------------------------
>  fs/quota/quota.c        |  22 +++++---
>  fs/super.c              |  81 +++++++++++++++++++++--------
>  include/linux/fs.h      |   2 +
>  include/linux/quota.h   |   1 -
>  10 files changed, 151 insertions(+), 160 deletions(-)
> 
> 							Thanks
> 								Honza
> 
> -- 
> Jan Kara <jack@...e.com>
> SUSE Labs, CR
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html