linux-ext4 - Re: [PATCH v2] fscrypt: Factor out bio specific functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170103142836.no7rp3hphj3czjto@thunk.org>
Date:   Tue, 3 Jan 2017 09:28:36 -0500
From:   Theodore Ts'o <tytso@....edu>
To:     Richard Weinberger <richard@....at>
Cc:     linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
        jaegeuk@...nel.org, hch@...radead.org, arnd@...db.de,
        dedekind1@...il.com, linux-mtd@...ts.infradead.org,
        adrian.hunter@...el.com, linux-ext4@...r.kernel.org,
        ebiggers@...gle.com, rdunlap@...radead.org, david@...ma-star.at
Subject: Re: [PATCH v2] fscrypt: Factor out bio specific functions

On Tue, Jan 03, 2017 at 10:49:26AM +0100, Richard Weinberger wrote:
> Ted,
> 
> Am 01.01.2017 um 22:47 schrieb Theodore Ts'o:
> > On Mon, Dec 19, 2016 at 12:25:32PM +0100, Richard Weinberger wrote:
> >> That way we can get rid of the direct dependency on CONFIG_BLOCK.
> >>
> >> Reported-by: Arnd Bergmann <arnd@...db.de>
> >> Reported-by: Randy Dunlap <rdunlap@...radead.org>
> >> Suggested-by: Christoph Hellwig <hch@...radead.org>
> >> Fixes: d475a507457b ("ubifs: Add skeleton for fscrypto")
> >> Signed-off-by: Richard Weinberger <richard@....at>
> > 
> > Applied, thanks.
> 
> Just to make sure, this fixes a build error and should
> go into Linus' tree ASAP.

I didn't consider this a build error since it could be fixed via a
config change.  And it is a pretty big patch, even if it is mostly
moving (not that git recognized it as such)...

git show --stat -M 58ae74683ae2c07cd717a91799edb50231061938
commit 58ae74683ae2c07cd717a91799edb50231061938
Author: Richard Weinberger <richard@....at>
Date:   Mon Dec 19 12:25:32 2016 +0100

    fscrypt: factor out bio specific functions
    
    That way we can get rid of the direct dependency on CONFIG_BLOCK.
    
    Fixes: d475a507457b ("ubifs: Add skeleton for fscrypto")
    Reported-by: Arnd Bergmann <arnd@...db.de>
    Reported-by: Randy Dunlap <rdunlap@...radead.org>
    Reviewed-by: Eric Biggers <ebiggers@...gle.com>
    Reviewed-by: Christoph Hellwig <hch@....de>
    Reviewed-by: David Gstir <david@...ma-star.at>
    Signed-off-by: Richard Weinberger <richard@....at>
    Signed-off-by: Theodore Ts'o <tytso@....edu>

 fs/crypto/Kconfig           |   1 -
 fs/crypto/Makefile          |   1 +
 fs/crypto/bio.c             | 145 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 fs/crypto/crypto.c          | 157 +++++++++----------------------------------------------------------------------------
 fs/crypto/fscrypt_private.h |  16 ++++++++-
 include/linux/fscrypto.h    |  11 +++---
 6 files changed, 184 insertions(+), 147 deletions(-)

						- Ted
						
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html