lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20170109142536.GK7495@dhcp22.suse.cz> Date: Mon, 9 Jan 2017 15:25:36 +0100 From: Michal Hocko <mhocko@...nel.org> To: Vlastimil Babka <vbabka@...e.cz> Cc: linux-mm@...ck.org, linux-fsdevel@...r.kernel.org, Andrew Morton <akpm@...ux-foundation.org>, Dave Chinner <david@...morbit.com>, djwong@...nel.org, Theodore Ts'o <tytso@....edu>, Chris Mason <clm@...com>, David Sterba <dsterba@...e.cz>, Jan Kara <jack@...e.cz>, ceph-devel@...r.kernel.org, cluster-devel@...hat.com, linux-nfs@...r.kernel.org, logfs@...fs.org, linux-xfs@...r.kernel.org, linux-ext4@...r.kernel.org, linux-btrfs@...r.kernel.org, linux-mtd@...ts.infradead.org, reiserfs-devel@...r.kernel.org, linux-ntfs-dev@...ts.sourceforge.net, linux-f2fs-devel@...ts.sourceforge.net, linux-afs@...ts.infradead.org, LKML <linux-kernel@...r.kernel.org> Subject: Re: [PATCH 4/8] xfs: use memalloc_nofs_{save,restore} instead of memalloc_noio* On Mon 09-01-17 15:08:27, Vlastimil Babka wrote: > On 01/06/2017 03:11 PM, Michal Hocko wrote: > > From: Michal Hocko <mhocko@...e.com> > > > > kmem_zalloc_large and _xfs_buf_map_pages use memalloc_noio_{save,restore} > > API to prevent from reclaim recursion into the fs because vmalloc can > > invoke unconditional GFP_KERNEL allocations and these functions might be > > called from the NOFS contexts. The memalloc_noio_save will enforce > > GFP_NOIO context which is even weaker than GFP_NOFS and that seems to be > > unnecessary. Let's use memalloc_nofs_{save,restore} instead as it should > > provide exactly what we need here - implicit GFP_NOFS context. > > > > Changes since v1 > > - s@...alloc_noio_restore@...alloc_nofs_restore@ in _xfs_buf_map_pages > > as per Brian Foster > > > > Signed-off-by: Michal Hocko <mhocko@...e.com> > > Not a xfs expert, but seems correct. > > Acked-by: Vlastimil Babka <vbabka@...e.cz> Thanks! > > Nit below: > > > --- > > fs/xfs/kmem.c | 10 +++++----- > > fs/xfs/xfs_buf.c | 8 ++++---- > > 2 files changed, 9 insertions(+), 9 deletions(-) > > > > diff --git a/fs/xfs/kmem.c b/fs/xfs/kmem.c > > index a76a05dae96b..d69ed5e76621 100644 > > --- a/fs/xfs/kmem.c > > +++ b/fs/xfs/kmem.c > > @@ -65,7 +65,7 @@ kmem_alloc(size_t size, xfs_km_flags_t flags) > > void * > > kmem_zalloc_large(size_t size, xfs_km_flags_t flags) > > { > > - unsigned noio_flag = 0; > > + unsigned nofs_flag = 0; > > void *ptr; > > gfp_t lflags; > > > > @@ -80,14 +80,14 @@ kmem_zalloc_large(size_t size, xfs_km_flags_t flags) > > * context via PF_MEMALLOC_NOIO to prevent memory reclaim re-entering > > * the filesystem here and potentially deadlocking. > > The comment above is now largely obsolete, or minimally should be > changed to PF_MEMALLOC_NOFS? --- diff --git a/fs/xfs/kmem.c b/fs/xfs/kmem.c index d69ed5e76621..0c9f94f41b6c 100644 --- a/fs/xfs/kmem.c +++ b/fs/xfs/kmem.c @@ -77,7 +77,7 @@ kmem_zalloc_large(size_t size, xfs_km_flags_t flags) * __vmalloc() will allocate data pages and auxillary structures (e.g. * pagetables) with GFP_KERNEL, yet we may be under GFP_NOFS context * here. Hence we need to tell memory reclaim that we are in such a - * context via PF_MEMALLOC_NOIO to prevent memory reclaim re-entering + * context via PF_MEMALLOC_NOFS to prevent memory reclaim re-entering * the filesystem here and potentially deadlocking. */ if (flags & KM_NOFS) I will fold it into the original patch. Thanks! -- Michal Hocko SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists