lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <bf7594a9-7e1a-0895-2d0e-df1f27502db1@suse.cz> Date: Mon, 9 Jan 2017 13:59:05 +0100 From: Vlastimil Babka <vbabka@...e.cz> To: Michal Hocko <mhocko@...nel.org>, linux-mm@...ck.org, linux-fsdevel@...r.kernel.org Cc: Andrew Morton <akpm@...ux-foundation.org>, Dave Chinner <david@...morbit.com>, djwong@...nel.org, Theodore Ts'o <tytso@....edu>, Chris Mason <clm@...com>, David Sterba <dsterba@...e.cz>, Jan Kara <jack@...e.cz>, ceph-devel@...r.kernel.org, cluster-devel@...hat.com, linux-nfs@...r.kernel.org, logfs@...fs.org, linux-xfs@...r.kernel.org, linux-ext4@...r.kernel.org, linux-btrfs@...r.kernel.org, linux-mtd@...ts.infradead.org, reiserfs-devel@...r.kernel.org, linux-ntfs-dev@...ts.sourceforge.net, linux-f2fs-devel@...ts.sourceforge.net, linux-afs@...ts.infradead.org, LKML <linux-kernel@...r.kernel.org>, Michal Hocko <mhocko@...e.com> Subject: Re: [PATCH 2/8] xfs: abstract PF_FSTRANS to PF_MEMALLOC_NOFS On 01/06/2017 03:11 PM, Michal Hocko wrote: > From: Michal Hocko <mhocko@...e.com> > > xfs has defined PF_FSTRANS to declare a scope GFP_NOFS semantic quite > some time ago. We would like to make this concept more generic and use > it for other filesystems as well. Let's start by giving the flag a > more generic name PF_MEMALLOC_NOFS which is in line with an exiting > PF_MEMALLOC_NOIO already used for the same purpose for GFP_NOIO > contexts. Replace all PF_FSTRANS usage from the xfs code in the first > step before we introduce a full API for it as xfs uses the flag directly > anyway. > > This patch doesn't introduce any functional change. > > Signed-off-by: Michal Hocko <mhocko@...e.com> > Reviewed-by: Brian Foster <bfoster@...hat.com> Acked-by: Vlastimil Babka <vbabka@...e.cz> A nit: > --- a/include/linux/sched.h > +++ b/include/linux/sched.h > @@ -2320,6 +2320,8 @@ extern void thread_group_cputime_adjusted(struct task_struct *p, cputime_t *ut, > #define PF_FREEZER_SKIP 0x40000000 /* Freezer should not count it as freezable */ > #define PF_SUSPEND_TASK 0x80000000 /* this thread called freeze_processes and should not be frozen */ > > +#define PF_MEMALLOC_NOFS PF_FSTRANS /* Transition to a more generic GFP_NOFS scope semantic */ I don't see why this transition is needed, as there are already no users of PF_FSTRANS after this patch. The next patch doesn't remove any more, so this is just extra churn IMHO. But not a strong objection. > + > /* > * Only the _current_ task can read/write to tsk->flags, but other > * tasks can access tsk->flags in readonly mode for example > -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists