linux-ext4 - Re: [PATCH 1/4] ext4: add debug_want_extra

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170113025835.hekkmb3jdxg2yhj5@thunk.org>
Date:   Thu, 12 Jan 2017 21:58:35 -0500
From:   Theodore Ts'o <tytso@....edu>
To:     Andreas Dilger <adilger@...ger.ca>
Cc:     Ext4 Developers List <linux-ext4@...r.kernel.org>,
        linux@...encehorizons.net
Subject: Re: [PATCH 1/4] ext4: add debug_want_extra_isize mount option

On Thu, Jan 12, 2017 at 12:19:37PM -0700, Andreas Dilger wrote:
> On Jan 11, 2017, at 8:49 PM, Theodore Ts'o <tytso@....edu> wrote:
> > 
> > In order to test the inode extra isize expansion code, it is useful to
> > be able to easily create file systems that have inodes with extra
> > isize values smaller than the current desired value.
> 
> Rather than adding all of the debug hooks as mount options, wouldn't it
> make more sense to add tunables via debugfs or as an attr_extra_isize or
> similar?

Debugfs would be lot more complicated to implement, and especially if
we had to set up a separate directory hierarchy for each file system.
And both debugfs and setting it up in sysfs would mean more runtime
memory in use for each file system this is mounted.  The mount option
is actually one of the simpler, lighter weight ways of adding the
debug hook.

What's the objection (or objections) you have to using mount options?

       	   	   	     	      - Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html