linux-ext4 - Re: [PATCH] libext2fs: don't ignore fsync errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170113173154.biiyax3lrnfjrivd@thunk.org>
Date:   Fri, 13 Jan 2017 12:31:54 -0500
From:   Theodore Ts'o <tytso@....edu>
To:     Eric Sandeen <sandeen@...hat.com>
Cc:     "linux-ext4@...r.kernel.org" <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH] libext2fs: don't ignore fsync errors

On Tue, Dec 20, 2016 at 09:23:29AM -0600, Eric Sandeen wrote:
> Today, if mke2fs experiences IO errors (say, on a thin device
> which filled up during mkfs), mke2fs is silent and returns
> success even though the filesystem was not properly created.
> 
> Catch errors from the io_channel_flush() callchain to
> fix this up.  Fix formatting of the printed error as
> well:
> 
> ...
> Creating journal (262144 blocks): done
> Writing superblocks and filesystem accounting information:          
> Warning, had trouble writing out superblocks.
> # echo $?
> 5
> 
> Signed-off-by: Eric Sandeen <sandeen@...hat.com>

Applied, thanks.

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html