linux-ext4 - Re: [PATCH] debugfs: increase inode reference count after link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170131034852.snc2xdfo26kg3icg@thunk.org>
Date:   Mon, 30 Jan 2017 22:48:52 -0500
From:   Theodore Ts'o <tytso@....edu>
To:     Artem Blagodarenko <artem.blagodarenko@...gate.com>
Cc:     linux-ext4@...r.kernel.org
Subject: Re: [PATCH] debugfs: increase inode reference count after link

On Fri, Jan 20, 2017 at 07:53:42PM +0300, Artem Blagodarenko wrote:
> Inode reference count is not increased after debugfs link command.
> This leads to inconsistent file system state.

That was deliberate.  Originally the "link" and "unlink" commands were
designed as a low-level command that didn't change the link count.
There are *many* commands in debugfs that can lead to inconsistent
file system state.  In fact, the original raison d'être of debugfs was
to create corrupted file systems to test e2fsck.  :-)

The "rm" command is user-friendly command that I added later which
decrements the link count and deallocates the blocks if the link count
goes to zero.

I never got around to adding a user-friendly 'ln' command which
creates the directory entry and also increments the link count.
That's mainly because no one has really needed or wanted that
functionality.  Or at least, no one has requested it up until now.

If you really want it, probably the best thing to do would be unalias
the "link" and "ln" commands, and make the "ln" command the
user-friendly command that works like the /bin/ln command.

Cheers,

						- Ted