linux-ext4 - Re: [PATCH] ext4: Fix data corruption in data=journal mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170201190649.yi7yiavisbi2zmpe@thunk.org>
Date:   Wed, 1 Feb 2017 14:06:49 -0500
From:   Theodore Ts'o <tytso@....edu>
To:     Jan Kara <jack@...e.cz>
Cc:     linux-ext4@...r.kernel.org, Al Viro <viro@...IV.linux.org.uk>,
        stable@...r.kernel.org
Subject: Re: [PATCH] ext4: Fix data corruption in data=journal mode

On Tue, Jan 10, 2017 at 01:37:53PM +0100, Jan Kara wrote:
> ext4_journalled_write_end() did not propely handle all the cases when
> generic_perform_write() did not copy all the data into the target page
> and could mark buffers with uninitialized contents as uptodate and dirty
> leading to possible data corruption (which would be quickly fixed by
> generic_perform_write() retrying the write but still). Fix the problem
> by carefully handling the case when the page that is written to is not
> uptodate.
> 
> CC: stable@...r.kernel.org
> Reported-by: Al Viro <viro@...IV.linux.org.uk>
> Signed-off-by: Jan Kara <jack@...e.cz>

Thanks, applied.

					- Ted