linux-ext4 - Re: [PATCH] fscrypt: split supp and notsupp declarations into their own headers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170207043938.52b4ta3pt6xyjlel@thunk.org>
Date:   Mon, 6 Feb 2017 23:39:39 -0500
From:   Theodore Ts'o <tytso@....edu>
To:     Eric Biggers <ebiggers3@...il.com>
Cc:     linux-fsdevel@...r.kernel.org, linux-fscrypt@...r.kernel.org,
        Jaegeuk Kim <jaegeuk@...nel.org>, linux-ext4@...r.kernel.org,
        linux-f2fs-devel@...ts.sourceforge.net,
        linux-mtd@...ts.infradead.org, Eric Biggers <ebiggers@...gle.com>
Subject: Re: [PATCH] fscrypt: split supp and notsupp declarations into their
 own headers

On Tue, Jan 24, 2017 at 10:58:06AM -0800, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@...gle.com>
> 
> Previously, each filesystem configured without encryption support would
> define all the public fscrypt functions to their notsupp_* stubs.  This
> list of #defines had to be updated in every filesystem whenever a change
> was made to the public fscrypt functions.  To make things more
> maintainable now that we have three filesystems using fscrypt, split the
> old header fscrypto.h into several new headers.  fscrypt_supp.h contains
> the real declarations and is included by filesystems when configured
> with encryption support, whereas fscrypt_notsupp.h contains the inline
> stubs and is included by filesystems when configured without encryption
> support.  fscrypt_common.h contains common declarations needed by both.
> 
> Signed-off-by: Eric Biggers <ebiggers@...gle.com>

Nice.  Thanks, applied.

					- Ted