linux-ext4 - Re: [PATCH 1/2] ext4: fix DAX write locking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170208194125.vtms65kpd42cfvwv@thunk.org>
Date:   Wed, 8 Feb 2017 14:41:25 -0500
From:   Theodore Ts'o <tytso@....edu>
To:     Jan Kara <jack@...e.cz>
Cc:     Christoph Hellwig <hch@....de>, linux-ext4@...r.kernel.org,
        linux-fsdevel@...r.kernel.org, linux-nvdimm@...1.01.org
Subject: Re: [PATCH 1/2] ext4: fix DAX write locking

On Wed, Jan 11, 2017 at 10:01:36AM +0100, Jan Kara wrote:
> On Tue 10-01-17 16:48:07, Christoph Hellwig wrote:
> > Unlike O_DIRECT DAX is not an optional opt-in feature selected by the
> > application, so we'll have to provide the traditional synchronіzation
> > of overlapping writes as we do for buffered writes.
> > 
> > This was broken historically for DAX, but got fixed for ext2 and XFS
> > as part of the iomap conversion.  Fix up ext4 as well.
> > 
> > Signed-off-by: Christoph Hellwig <hch@....de>
> 
> Makes sense. You can add:
> 
> Reviewed-by: Jan Kara <jack@...e.cz>
> 
> Ted, can you please pick it up? Thanks!

Thanks, applied to the ext4 tree.

					- Ted