linux-ext4 - Re: [PATCH] ext4: preload block group descriptors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170228161956.GE5266@birch.djwong.org>
Date:   Tue, 28 Feb 2017 08:19:56 -0800
From:   "Darrick J. Wong" <darrick.wong@...cle.com>
To:     Artem Blagodarenko <artem.blagodarenko@...il.com>
Cc:     linux-ext4@...r.kernel.org, alexey.lyashkov@...il.com,
        Andrew Perepechko <andrew.perepechko@...gate.com>
Subject: Re: [PATCH] ext4: preload block group descriptors

On Mon, Feb 20, 2017 at 07:45:53PM +0300, Artem Blagodarenko wrote:
> From: Andrew Perepechko <andrew.perepechko@...gate.com>
> 
> With enabled meta_bg option block group descriptors
> reading IO is not sequential and requires optimization.
> 
> Signed-off-by: Andrew Perepechko <andrew.perepechko@...gate.com>
> ---
>  fs/ext4/super.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> index a673558..0e52c91 100644
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -3879,6 +3879,12 @@ static int ext4_fill_super(struct super_block *sb, void *data, int silent)
>  
>  	bgl_lock_init(sbi->s_blockgroup_lock);
>  
> +	/* Pre-read the descriptors into the buffer cache */
> +	for (i = 0; i < db_count; i++) {
> +		block = descriptor_loc(sb, logical_sb_block, i);
> +		sb_breadahead(sb, block);
> +	}

Why does the libext2fs patch start readahead only on the meta bgs
whereas this patch starts it for all of them?  I suppose it's just as
well that the kernel prefetches all of them, but I was curious. :)

--D

> +
>  	for (i = 0; i < db_count; i++) {
>  		block = descriptor_loc(sb, logical_sb_block, i);
>  		sbi->s_group_desc[i] = sb_bread_unmovable(sb, block);
> -- 
> 1.8.3.1
>