linux-ext4 - Re: [PATCH] generic: require journal in shutdown tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170309055434.ufeyr2u2vl6p7bzv@thunk.org>
Date:   Thu, 9 Mar 2017 00:54:34 -0500
From:   Theodore Ts'o <tytso@....edu>
To:     Eryu Guan <eguan@...hat.com>
Cc:     fstests@...r.kernel.org, linux-ext4@...r.kernel.org
Subject: Re: [PATCH] generic: require journal in shutdown tests

On Tue, Mar 07, 2017 at 02:16:09PM +0800, Eryu Guan wrote:
> Tests in shutdown group are supposed to test journal recovery after
> filesystem shutdown, and the tests assume the filesystem in test has
> journal support. But with the ext4 shutdown function added in
> 4.11-rc kernel, ext2 gains shutdown support too when driving with
> ext4 driver, so generic/051 fails because fs corruption after test.
> 
> Adding _require_metadata_journaling to all generic tests in shutdown
> group to ensure there's journal present.
> 
> generic/050 is skipped because it has _require_scratch_nocheck,
> which indicates no fsck is done after test.
> 
> Signed-off-by: Eryu Guan <eguan@...hat.com>

Reviewed-by: Theodore Ts'o <tytso@....edu>

Thanks!!

					- Ted