linux-ext4 - Re: [PATCH] ext4: mark inode dirty after converting inline directory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170315185312.3bd7xc4m37cx3bn2@thunk.org>
Date:   Wed, 15 Mar 2017 14:53:12 -0400
From:   Theodore Ts'o <tytso@....edu>
To:     Eric Biggers <ebiggers3@...il.com>
Cc:     linux-ext4@...r.kernel.org,
        Andreas Dilger <adilger.kernel@...ger.ca>,
        linux-fscrypt@...r.kernel.org, Eric Biggers <ebiggers@...gle.com>,
        stable@...r.kernel.org
Subject: Re: [PATCH] ext4: mark inode dirty after converting inline directory

On Wed, Feb 22, 2017 at 01:22:46PM -0800, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@...gle.com>
> 
> If ext4_convert_inline_data() was called on a directory with inline
> data, the filesystem was left in an inconsistent state (as considered by
> e2fsck) because the file size was not increased to cover the new block.
> This happened because the inode was not marked dirty after i_disksize
> was updated.  Fix this by marking the inode dirty at the end of
> ext4_finish_convert_inline_dir().
> 
> This bug was probably not noticed before because most users mark the
> inode dirty afterwards for other reasons.  But if userspace executed
> FS_IOC_SET_ENCRYPTION_POLICY with invalid parameters, as exercised by
> 'kvm-xfstests -c adv generic/396', then the inode was never marked dirty
> after updating i_disksize.
> 
> Cc: stable@...r.kernel.org
> Signed-off-by: Eric Biggers <ebiggers@...gle.com>

Thanks, applied.

					- Ted