linux-ext4 - Re: [PATCH] fscrypt: eliminate ->prepare

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170316151831.l6hzeszqwzwqzsjl@thunk.org>
Date:   Thu, 16 Mar 2017 11:18:31 -0400
From:   Theodore Ts'o <tytso@....edu>
To:     Eric Biggers <ebiggers3@...il.com>
Cc:     linux-fscrypt@...r.kernel.org, Jaegeuk Kim <jaegeuk@...nel.org>,
        linux-ext4@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        Eric Biggers <ebiggers@...gle.com>
Subject: Re: [PATCH] fscrypt: eliminate ->prepare_context() operation

On Wed, Feb 22, 2017 at 01:25:14PM -0800, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@...gle.com>
> 
> The only use of the ->prepare_context() fscrypt operation was to allow
> ext4 to evict inline data from the inode before ->set_context().
> However, there is no reason why this cannot be done as simply the first
> step in ->set_context(), and in fact it makes more sense to do it that
> way because then the policy modes and flags get validated before any
> real work is done.  Therefore, merge ext4_prepare_context() into
> ext4_set_context(), and remove ->prepare_context().
> 
> Signed-off-by: Eric Biggers <ebiggers@...gle.com>

Thanks, applied.

					- Ted