linux-ext4 - Re: [PATCH] e2fsck: fix type mismatches in quota warning message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 1 Apr 2017 12:16:15 -0400
From:   Theodore Ts'o <tytso@....edu>
To:     Eric Whitney <enwlinux@...il.com>
Cc:     linux-ext4@...r.kernel.org
Subject: Re: [PATCH] e2fsck: fix type mismatches in quota warning message

On Fri, Mar 31, 2017 at 07:21:59PM -0400, Eric Whitney wrote:
> The conversion operations in the format control strings found in the
> fprintf call used to print the quota warning message do not match the
> types of their corresponding arguments.  Although this probably hasn't
> generally been a problem, it obfuscates a bigalloc quota accounting bug
> where the reported actual quota goes negative.
> 
> Clean up the mismatches and some unnecessary casts.  While we're at it,
> fix a spelling nit in a related comment.
> 
> Signed-off-by: Eric Whitney <enwlinux@...il.com>

Thanks, applied.

					- Ted