linux-ext4 - Re: [PATCH v2] ext4: Clear lockdep subtype for quota files on quota off

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170520023946.coy7u5bfsbae35dh@thunk.org>
Date:   Fri, 19 May 2017 22:39:46 -0400
From:   Theodore Ts'o <tytso@....edu>
To:     Jan Kara <jack@...e.cz>
Cc:     linux-ext4@...r.kernel.org,
        Ross Zwisler <ross.zwisler@...ux.intel.com>,
        Andreas Dilger <adilger@...ger.ca>
Subject: Re: [PATCH v2] ext4: Clear lockdep subtype for quota files on quota
 off

On Tue, May 09, 2017 at 02:22:47PM +0200, Jan Kara wrote:
> Quota files have special ranking of i_data_sem lock. We inform lockdep
> about it when turning on quotas however when turning quotas off, we
> don't clear the lockdep subclass from i_data_sem lock and thus when the
> inode gets later reused for a normal file or directory, lockdep gets
> confused and complains about possible deadlocks. Fix the problem by
> resetting lockdep subclass of i_data_sem on quota off.
> 
> Fixes: daf647d2dd58cec59570d7698a45b98e580f2076
> Reported-and-tested-by: Ross Zwisler <ross.zwisler@...ux.intel.com>
> Reviewed-by: Andreas Dilger <adilger@...ger.ca>
> Signed-off-by: Jan Kara <jack@...e.cz>

Thanks, applied.

					- Ted