linux-ext4 - Re: [PATCH 2/2] ext4: Fix off-by-in in loop termination in ext4_find_unwritten

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170520041534.25req27q6epii3rr@thunk.org>
Date:   Sat, 20 May 2017 00:15:34 -0400
From:   Theodore Ts'o <tytso@....edu>
To:     Jan Kara <jack@...e.cz>
Cc:     linux-ext4@...r.kernel.org
Subject: Re: [PATCH 2/2] ext4: Fix off-by-in in loop termination in
 ext4_find_unwritten_pgoff()

On Thu, May 18, 2017 at 12:49:42PM +0200, Jan Kara wrote:
> There is an off-by-one error in loop termination conditions in
> ext4_find_unwritten_pgoff() since 'end' may index a page beyond end of
> desired range if 'endoff' is page aligned. It doesn't have any visible
> effects but still it is good to fix it.
> 
> Signed-off-by: Jan Kara <jack@...e.cz>

Thanks, applied.

					- Ted