linux-ext4 - Re: [PATCH] e2fsck: fix sparse bmap to extent conversion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e8704df9-dac3-d7c8-2907-b116d9a3f2e6@dragonfly.plus.com>
Date:   Thu, 25 May 2017 14:11:52 +0100
From:   Marc Thomas <marc@...gonfly.plus.com>
To:     "Theodore Ts'o" <tytso@....edu>, linux-ext4@...r.kernel.org
Cc:     "Darrick J. Wong" <darrick.wong@...cle.com>
Subject: Re: [PATCH] e2fsck: fix sparse bmap to extent conversion

Thank you both for the rapid turn-around with this patch.
I can confirm it solves the original problem with the in-place ext3 to
ext4 conversion I'm doing.

As regards the f_detect_junk test, it seems a change in "debugfs" is
emitting an extra message "Checksum errors in superblock!  Retrying..."
which is not present in the "expect" output.
It appears this was introduced in commit
https://git.kernel.org/pub/scm/fs/ext2/e2fsprogs.git/commit/?id=bf615bb0ccadeb1579463f94a2a4752e7ec53f57

Perhaps debugfs could print that message to stderr so it's not picked up?

I'm testing with the git master branch, but my git skills are weak so I
could well be doing something wrong!

Kind Regards,
Marc