linux-ext4 - Re: [PATCH] ext4: fix off-by-one on max nr_pages in ext4_find_unwritten

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 27 May 2017 14:06:24 +0800
From:   Eryu Guan <guaneryu@...il.com>
To:     Theodore Ts'o <tytso@....edu>
Cc:     Jan Kara <jack@...e.cz>, Eryu Guan <eguan@...hat.com>,
        linux-ext4@...r.kernel.org
Subject: Re: [PATCH] ext4: fix off-by-one on max nr_pages in
 ext4_find_unwritten_pgoff()

Hi Ted,

On Wed, May 24, 2017 at 06:03:40PM -0400, Theodore Ts'o wrote:
> On Tue, May 23, 2017 at 10:34:32AM +0200, Jan Kara wrote:
> > > Cc: stable@...r.kernel.org # v3.7+
> > > Signed-off-by: Eryu Guan <eguan@...hat.com>
> > 
> > Yeah, thanks for fixing this! Actually this is a bug introduced by my
> > recent fixes. Previously, 'end' used to be "one block after the end" and so
> > the math worked out correctly :-|. You can add:
> > 
> > Reviewed-by: Jan Kara <jack@...e.cz>
> 
> Thanks, applied.  (And I've dropped the Cc: stable)

(Sorry for the late response, not sure why my redhat account didn't get
this email, and my gmail account just got this mail today..)

Actually this is an old bug and can be reproduced without Jan's
patchset. So I think "Cc: stable" is still needed.

Thanks,
Eryu