linux-ext4 - Re: [Cluster-devel] [PATCH 00/35 v1] pagevec API cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170601120556.GD23077@quack2.suse.cz>
Date:   Thu, 1 Jun 2017 14:05:56 +0200
From:   Jan Kara <jack@...e.cz>
To:     Christoph Hellwig <hch@...radead.org>
Cc:     Jan Kara <jack@...e.cz>, linux-mm@...ck.org,
        cluster-devel@...hat.com, linux-nilfs@...r.kernel.org,
        tytso@....edu, linux-xfs@...r.kernel.org,
        "Yan, Zheng" <zyan@...hat.com>,
        "Darrick J . Wong" <darrick.wong@...cle.com>,
        Hugh Dickins <hughd@...gle.com>,
        linux-f2fs-devel@...ts.sourceforge.net,
        David Howells <dhowells@...hat.com>,
        David Sterba <dsterba@...e.com>, ceph-devel@...r.kernel.org,
        Nadia Yvette Chambers <nyc@...omorphy.com>,
        Ryusuke Konishi <konishi.ryusuke@....ntt.co.jp>,
        Jaegeuk Kim <jaegeuk@...nel.org>,
        Ilya Dryomov <idryomov@...il.com>, linux-ext4@...r.kernel.org,
        linux-afs@...ts.infradead.org, linux-btrfs@...r.kernel.org
Subject: Re: [Cluster-devel] [PATCH 00/35 v1] pagevec API cleanups

On Thu 01-06-17 04:36:04, Christoph Hellwig wrote:
> On Thu, Jun 01, 2017 at 11:32:10AM +0200, Jan Kara wrote:
> > * Implement ranged variants for pagevec_lookup and find_get_ functions. Lot
> >   of callers actually want a ranged lookup and we unnecessarily opencode this
> >   in lot of them.
> 
> How does this compare to Kents page cache iterators:
> 
> http://www.spinics.net/lists/linux-mm/msg104737.html

Interesting. I didn't know about that work. I guess the tradeoff is pretty
obvious - my patches are more conservative (changing less) and as a result
the API is not as neat as Kent's one. That being said I was also thinking
about something similar to what Kent did but what I didn't like about such
iterator is that you still need to specially handle the cases where you
break out of the loop (you need to do that with pagevecs too but there it
is kind of obvious from the API).

								Honza
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR