linux-ext4 - Re: [PATCH] libext2fs: Fix fsync(2) detection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170608160404.euiprmtcvlo76n3g@thunk.org>
Date:   Thu, 8 Jun 2017 12:04:04 -0400
From:   Theodore Ts'o <tytso@....edu>
To:     Jan Kara <jack@...e.cz>
Cc:     linux-ext4@...r.kernel.org
Subject: Re: [PATCH] libext2fs: Fix fsync(2) detection

On Wed, Jun 07, 2017 at 03:31:14PM +0200, Jan Kara wrote:
> For some reason lib/config.h.in was missing a definition of HAVE_FSYNC
> and as a result lib/config.h never had HAVE_FSYNC defined. As a result
> we never called fsync(2) for example from
> lib/ext2fs/unix_io.c:unix_flush() when we finished creating filesystem
> and could miss IO errors happening during creating of the filesystem.
> Test generic/405 exposes this problem.
> 
> Fix the problem by defining HAVE_FSYNC in lib/config.h.in.
> 
> Signed-off-by: Jan Kara <jack@...e.cz>

Thanks for tracking down this regression.  This bug was introduced by
my cherry-picking in changes from the Android AOSP version of
e2fsprogs a few weeks ago.  I was wondering why generic/405 had
regressed.

Thanks, applied.

					- Ted