lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20170612040236.GA7352@linux.intel.com> Date: Sun, 11 Jun 2017 22:02:36 -0600 From: Ross Zwisler <ross.zwisler@...ux.intel.com> To: Dan Williams <dan.j.williams@...el.com> Cc: Ross Zwisler <ross.zwisler@...ux.intel.com>, Andrew Morton <akpm@...ux-foundation.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, linux-xfs@...r.kernel.org, Theodore Ts'o <tytso@....edu>, Matthew Wilcox <mawilcox@...rosoft.com>, "Darrick J. Wong" <darrick.wong@...cle.com>, Jonathan Corbet <corbet@....net>, Steven Rostedt <rostedt@...dmis.org>, linux-doc@...r.kernel.org, linux-mm <linux-mm@...ck.org>, Dave Hansen <dave.hansen@...el.com>, Ingo Molnar <mingo@...hat.com>, Andreas Dilger <adilger.kernel@...ger.ca>, Alexander Viro <viro@...iv.linux.org.uk>, linux-fsdevel <linux-fsdevel@...r.kernel.org>, Jan Kara <jack@...e.cz>, ext4 hackers <linux-ext4@...r.kernel.org>, Christoph Hellwig <hch@....de>, "linux-nvdimm@...ts.01.org" <linux-nvdimm@...ts.01.org> Subject: Re: [PATCH 1/3] mm: add vm_insert_mixed_mkwrite() On Fri, Jun 09, 2017 at 08:35:08PM -0700, Dan Williams wrote: > On Fri, Jun 9, 2017 at 8:03 PM, Ross Zwisler > <ross.zwisler@...ux.intel.com> wrote: > > And vm_insert_mixed_mkwrite() and vm_insert_mixed() are redundant with only > > the insert_pfn() line differing? This doesn't seem better...unless I'm > > missing something? > > > > The way it is, vm_insert_mixed_mkwrite() also closely matches > > insert_pfn_pmd(), which we use in the PMD case and which also takes a 'write' > > boolean which works the same as our newly added 'mkwrite'. > > Hmm, but now the pfn and pmd cases are inconsistent, if you put the > flag name in the function then don't add an argument, or make it like > the pmd case and add an argument to vm_insert_mixed(). I prefer the > former. Okay, I'll fix this for v2. Thanks for the review.
Powered by blists - more mailing lists