lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20170612122316.13244-16-jlayton@redhat.com> Date: Mon, 12 Jun 2017 08:23:07 -0400 From: Jeff Layton <jlayton@...hat.com> To: Andrew Morton <akpm@...ux-foundation.org>, Al Viro <viro@...IV.linux.org.uk>, Jan Kara <jack@...e.cz>, tytso@....edu, axboe@...nel.dk, mawilcox@...rosoft.com, ross.zwisler@...ux.intel.com, corbet@....net, Chris Mason <clm@...com>, Josef Bacik <jbacik@...com>, David Sterba <dsterba@...e.com>, "Darrick J . Wong" <darrick.wong@...cle.com> Cc: linux-fsdevel@...r.kernel.org, linux-mm@...ck.org, linux-ext4@...r.kernel.org, linux-xfs@...r.kernel.org, linux-btrfs@...r.kernel.org, linux-block@...r.kernel.org Subject: [PATCH v6 12/13] xfs: minimal conversion to errseq_t writeback error reporting Just check and advance the data errseq_t in struct file before before returning from fsync on normal files. Internal filemap_* callers are left as-is. We also set the FS_WB_ERRSEQ flag just for completeness sake. Not much is really using it at this point. Signed-off-by: Jeff Layton <jlayton@...hat.com> --- fs/xfs/xfs_file.c | 15 +++++++++++---- fs/xfs/xfs_super.c | 2 +- 2 files changed, 12 insertions(+), 5 deletions(-) diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c index 5fb5a0958a14..bc3b1575e8db 100644 --- a/fs/xfs/xfs_file.c +++ b/fs/xfs/xfs_file.c @@ -134,7 +134,7 @@ xfs_file_fsync( struct inode *inode = file->f_mapping->host; struct xfs_inode *ip = XFS_I(inode); struct xfs_mount *mp = ip->i_mount; - int error = 0; + int error = 0, err2; int log_flushed = 0; xfs_lsn_t lsn = 0; @@ -142,10 +142,12 @@ xfs_file_fsync( error = filemap_write_and_wait_range(inode->i_mapping, start, end); if (error) - return error; + goto out; - if (XFS_FORCED_SHUTDOWN(mp)) - return -EIO; + if (XFS_FORCED_SHUTDOWN(mp)) { + error = -EIO; + goto out; + } xfs_iflags_clear(ip, XFS_ITRUNCATED); @@ -197,6 +199,11 @@ xfs_file_fsync( mp->m_logdev_targp == mp->m_ddev_targp) xfs_blkdev_issue_flush(mp->m_ddev_targp); +out: + err2 = filemap_report_wb_err(file); + if (!error) + error = err2; + return error; } diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c index 455a575f101d..28d3be187025 100644 --- a/fs/xfs/xfs_super.c +++ b/fs/xfs/xfs_super.c @@ -1758,7 +1758,7 @@ static struct file_system_type xfs_fs_type = { .name = "xfs", .mount = xfs_fs_mount, .kill_sb = kill_block_super, - .fs_flags = FS_REQUIRES_DEV, + .fs_flags = FS_REQUIRES_DEV | FS_WB_ERRSEQ, }; MODULE_ALIAS_FS("xfs"); -- 2.13.0
Powered by blists - more mailing lists