lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <1497963376.4555.4.camel@redhat.com> Date: Tue, 20 Jun 2017 08:56:16 -0400 From: Jeff Layton <jlayton@...hat.com> To: Christoph Hellwig <hch@...radead.org> Cc: Andrew Morton <akpm@...ux-foundation.org>, Al Viro <viro@...IV.linux.org.uk>, Jan Kara <jack@...e.cz>, tytso@....edu, axboe@...nel.dk, mawilcox@...rosoft.com, ross.zwisler@...ux.intel.com, corbet@....net, Chris Mason <clm@...com>, Josef Bacik <jbacik@...com>, David Sterba <dsterba@...e.com>, "Darrick J . Wong" <darrick.wong@...cle.com>, Carlos Maiolino <cmaiolino@...hat.com>, Eryu Guan <eguan@...hat.com>, David Howells <dhowells@...hat.com>, linux-fsdevel@...r.kernel.org, linux-mm@...ck.org, linux-ext4@...r.kernel.org, linux-xfs@...r.kernel.org, linux-btrfs@...r.kernel.org, linux-block@...r.kernel.org Subject: Re: [PATCH v7 11/22] fs: new infrastructure for writeback error handling and reporting On Tue, 2017-06-20 at 05:34 -0700, Christoph Hellwig wrote: > > @@ -393,6 +394,7 @@ struct address_space { > > gfp_t gfp_mask; /* implicit gfp mask for allocations */ > > struct list_head private_list; /* ditto */ > > void *private_data; /* ditto */ > > + errseq_t wb_err; > > } __attribute__((aligned(sizeof(long)))); > > /* > > * On most architectures that alignment is already the case; but > > @@ -847,6 +849,7 @@ struct file { > > * Must not be taken from IRQ context. > > */ > > spinlock_t f_lock; > > + errseq_t f_wb_err; > > atomic_long_t f_count; > > unsigned int f_flags; > > fmode_t f_mode; > > Did you check the sizes of the structure before and after? > These places don't look like holes in the packing, but there probably > are some available. > Yes. That one actually plugs a 4 byte hole in struct file on x86_64. > > +static inline int filemap_check_wb_err(struct address_space *mapping, errseq_t since) > > Overly long line here (the patch has a few more) > Ok, I'll fix those up. -- Jeff Layton <jlayton@...hat.com>
Powered by blists - more mailing lists