lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20170621212142.16581-12-tahsin@google.com> Date: Wed, 21 Jun 2017 14:21:22 -0700 From: Tahsin Erdogan <tahsin@...gle.com> To: Andreas Dilger <adilger@...ger.ca>, "Darrick J . Wong" <darrick.wong@...cle.com>, Jan Kara <jack@...e.cz>, Theodore Ts'o <tytso@....edu>, linux-ext4@...r.kernel.org Cc: linux-kernel@...r.kernel.org, Tahsin Erdogan <tahsin@...gle.com> Subject: [PATCH 12/32] ext4: add missing le32_to_cpu(e_value_inum) conversions Two places in code missed converting xattr inode number using le32_to_cpu(). Signed-off-by: Tahsin Erdogan <tahsin@...gle.com> --- fs/ext4/xattr.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/fs/ext4/xattr.c b/fs/ext4/xattr.c index 8e855fc2eb03..4dd8be16d175 100644 --- a/fs/ext4/xattr.c +++ b/fs/ext4/xattr.c @@ -1997,6 +1997,7 @@ ext4_xattr_delete_inode(handle_t *handle, struct inode *inode, struct ext4_inode *raw_inode; struct ext4_iloc iloc; struct ext4_xattr_entry *entry; + unsigned int ea_ino; int credits = 3, error = 0; if (!ext4_test_inode_state(inode, EXT4_STATE_XATTR)) @@ -2011,8 +2012,8 @@ ext4_xattr_delete_inode(handle_t *handle, struct inode *inode, entry = EXT4_XATTR_NEXT(entry)) { if (!entry->e_value_inum) continue; - if (ext4_expand_ino_array(lea_ino_array, - entry->e_value_inum) != 0) { + ea_ino = le32_to_cpu(entry->e_value_inum); + if (ext4_expand_ino_array(lea_ino_array, ea_ino) != 0) { brelse(iloc.bh); goto cleanup; } @@ -2044,8 +2045,8 @@ ext4_xattr_delete_inode(handle_t *handle, struct inode *inode, entry = EXT4_XATTR_NEXT(entry)) { if (!entry->e_value_inum) continue; - if (ext4_expand_ino_array(lea_ino_array, - entry->e_value_inum) != 0) + ea_ino = le32_to_cpu(entry->e_value_inum); + if (ext4_expand_ino_array(lea_ino_array, ea_ino) != 0) goto cleanup; entry->e_value_inum = 0; } -- 2.13.1.611.g7e3b11ae1-goog
Powered by blists - more mailing lists