linux-ext4 - Re: [PATCH 11/32] ext4: clean up ext4_xattr_inode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170622015830.x26e5pbmmjj7tmzy@thunk.org>
Date:   Wed, 21 Jun 2017 21:58:30 -0400
From:   Theodore Ts'o <tytso@....edu>
To:     Tahsin Erdogan <tahsin@...gle.com>
Cc:     Andreas Dilger <adilger@...ger.ca>,
        "Darrick J . Wong" <darrick.wong@...cle.com>,
        Jan Kara <jack@...e.cz>, linux-ext4@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 11/32] ext4: clean up ext4_xattr_inode_get()

On Wed, Jun 21, 2017 at 02:21:21PM -0700, Tahsin Erdogan wrote:
> The input and output values of *size parameter are equal on successful
> return from ext4_xattr_inode_get(). On error return, the callers ignore
> the output value so there is no need to update it.
> 
> Also check for NULL return from ext4_bread(). If the actual xattr inode
> size happens to be smaller than the expected size, ext4_bread() may
> return NULL which would indicate data corruption.
> 
> Signed-off-by: Tahsin Erdogan <tahsin@...gle.com>

Thanks, applied.

					- Ted